Segment: update to v1 API #287
Conversation
Current coverage is 98.31% (diff: 100%)@@ master #287 diff @@
==========================================
Files 98 98
Lines 1418 1421 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1394 1397 +3
Misses 24 24
Partials 0 0
|
| Humans don't think of lions as being like cats, but they are. | ||
| </Segment> | ||
| <Message className='bottom attached warning'> | ||
| <Message attached='bottom' className='warning'> |
There was a problem hiding this comment.
<Message /> has not yet been updated to v1 API, so the attached prop won't work here.
There was a problem hiding this comment.
My mistake, have pushed a revert
| } | ||
|
|
||
| HeaderH1.defaultProps = { | ||
| _sdClass: 'sd-header-h1', |
There was a problem hiding this comment.
Heads up, I've finished removing all sd-* classes, see #301. Rebase to master to get the update. The test for the sd-* class has been inverted to fail if any sd- class exists.
Let's remove all sd-* classes from all PRs. 👍
levithomason
changed the title
|
Heads up, I'm resuming work on this PR along side the Button PR. |
levithomason
force-pushed
the
feature/segment
branch
from
26ca3b6 to
7bebee8
Compare
levithomason
force-pushed
the
feature/segment
branch
from
7bebee8 to
a87c536
Compare
|
I've rebased this to master, squashed to 2 commits, finished features, and added/fixed tests. The last thing to do is round out the examples. There are a few missing. Also, something is odd with the circular example. |
levithomason
force-pushed
the
feature/segment
branch
2 times, most recently
from
5ba00d0 to
4175a90
Compare
levithomason
force-pushed
the
feature/segment
branch
from
4175a90 to
7c532da
Compare
|
Released in |
No description provided.