fix(Docs): Add babel-polyfill so that the Docs work in IE11 #2884
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2884 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 161 161
Lines 2733 2733
=======================================
Hits 2724 2724
Misses 9 9Continue to review full report at Codecov.
|
mihai-dinculescu
changed the title
|
Can you throw in useBuiltIns: 'entry' Into the .babelrc file for the babel-preset-env plugin? |
package.json
Outdated
| @@ -90,6 +90,7 @@ | |||
| "babel-plugin-lodash": "^3.2.11", | |||
| "babel-plugin-transform-react-handled-props": "^1.0.0", | |||
| "babel-plugin-transform-react-remove-prop-types": "^0.4.13", | |||
| "babel-polyfill": "^6.26.0", | |||
|
yup |
build/preset-env.js
Outdated
| @@ -26,6 +26,7 @@ const browsers = [ | |||
|
|
|||
| const envOptions = { | |||
| targets: { browsers }, | |||
| useBuiltIns: 'entry', | |||
There was a problem hiding this comment.
This change will affect also dist build that will be published to NPM. We also using transform runtime.
I am not sure that proposed changes are safe.
There was a problem hiding this comment.
I'm not confident that this setting helps the docs. Albeit crude, my tests showed no difference in network traffic. I'll take it out for now.
|
This is an easy merge, however, what feature are we using that is not IE 11 compliant? This is a target browser. |
|
|
|
Thanks |
|
Released in |
No description provided.