Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Input): expose select() method from ref #2928

Merged
merged 3 commits into from
Jul 6, 2018

Conversation

kierenj
Copy link
Contributor

@kierenj kierenj commented Jun 20, 2018

(Just as "focus" is currently)

(Just as "focus" is currently)
@welcome
Copy link

welcome bot commented Jun 20, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@levithomason
Copy link
Member

Great, let's also add a test for this. You can reference the focus test as an example:

@codecov-io
Copy link

codecov-io commented Jun 21, 2018

Codecov Report

Merging #2928 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2928      +/-   ##
==========================================
+ Coverage   99.96%   99.96%   +<.01%     
==========================================
  Files         163      163              
  Lines        2738     2739       +1     
==========================================
+ Hits         2737     2738       +1     
  Misses          1        1
Impacted Files Coverage Δ
src/elements/Input/Input.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e71c570...88da8cc. Read the comment docs.

@levithomason
Copy link
Member

Merged master and added a test. This is ready for merge once CI passes.

@levithomason levithomason changed the title Bubble up "select" from for inputs feat(Input): expose select() method from ref Jul 6, 2018
@levithomason levithomason merged commit a27a917 into Semantic-Org:master Jul 6, 2018
@welcome
Copy link

welcome bot commented Jul 6, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@levithomason
Copy link
Member

Released in semantic-ui-react@0.82.0.

@kierenj
Copy link
Contributor Author

kierenj commented Jul 6, 2018

@levithomason thanks for seeing this one through properly - I had intended to get to the test but other things got in the way. Much appreciated 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants