Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Icon): fix handling of aria-label #2947

Merged
merged 2 commits into from
Jun 25, 2018
Merged

fix(Icon): fix handling of aria-label #2947

merged 2 commits into from
Jun 25, 2018

Conversation

layershifter
Copy link
Member

Fixes #2946.

Also improves handling of aria-hidden.

Oleksandr Fediashov added 2 commits June 25, 2018 16:31
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
@codecov-io
Copy link

Codecov Report

Merging #2947 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2947      +/-   ##
==========================================
+ Coverage   99.78%   99.78%   +<.01%     
==========================================
  Files         161      161              
  Lines        2760     2763       +3     
==========================================
+ Hits         2754     2757       +3     
  Misses          6        6
Impacted Files Coverage Δ
src/elements/Icon/Icon.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caee404...e80e84d. Read the comment docs.

@levithomason levithomason merged commit 02af086 into master Jun 25, 2018
@levithomason levithomason deleted the fix/icon-aria branch June 25, 2018 21:34
@levithomason
Copy link
Member

Released in semantic-ui-react@0.81.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants