-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): remove component page hash replacement #3528
fix(docs): remove component page hash replacement #3528
Conversation
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## master #3528 +/- ##
=======================================
Coverage 99.82% 99.82%
=======================================
Files 172 172
Lines 2795 2795
=======================================
Hits 2790 2790
Misses 5 5 Continue to review full report at Codecov.
|
@grumblerchester thanks for pushing this. It's weird, I removed this part of code and it still works 🦀 Can you please confirm? |
@layershifter Yeah! Deletion resolves the issue too and everything works absolutely fine for old hashes. |
Can you please clarify what is "old" and "new" hashes? |
@layershifter Please see isOldHash that is used by getFormattedHash. |
* fix(docs): Component page hash replacement. * Update ComponentDoc.js * Update ComponentDoc.js * Update ComponentDoc.js
Closes #3527 and affects #2732 (removes
componentWillMount
fromComponentDoc
).