Refactor utils #388
Merged
Refactor utils #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 93.75% (diff: 95.83%)@@ master #388 diff @@
==========================================
Files 73 73
Lines 946 944 -2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 887 885 -2
Misses 59 59
Partials 0 0
|
levithomason
force-pushed
the
refactor/utils
branch
8 times, most recently
from
5874922 to
ea9cea7
Compare
| @@ -18,7 +18,7 @@ CONTRIBUTING | |||
| - [API](#api) | |||
| - [SUI HTML Classes](#sui-html-classes) | |||
| - [API Patterns](#api-patterns) | |||
| - [Prop Utils](#prop-utils) | |||
| - [Utilities](#utilities) | |||
There was a problem hiding this comment.
Updated scripts to update TOC on every build.
levithomason
force-pushed
the
refactor/utils
branch
from
ea9cea7 to
da2d661
Compare
| <a | ||
| href='https://github.com/TechnologyAdvice/stardust/blob/master/CONTRIBUTING.md' | ||
| > contribute</a>! | ||
| </Message.Content> |
There was a problem hiding this comment.
Example of housekeeping, the previous usage of Message here threw warnings as we do not support it any longer.
levithomason
force-pushed
the
refactor/utils
branch
from
da2d661 to
a730f7d
Compare
| @@ -10,4 +10,4 @@ requireDir('./gulp/tasks') | |||
| // do not use tasks/default | |||
| // the default task must be loaded after all other tasks | |||
| // requireDir above loads all our tasks in alphabetical order | |||
| gulp.task('default', gulp.series('generate-docs-json', 'serve', 'watch')) | |||
| gulp.task('default', gulp.series('docs', 'serve', 'watch')) | |||
There was a problem hiding this comment.
Housekeeping: build docs completely on npm start. This cleans/rebuild the doc dist including images.
layershifter
pushed a commit
that referenced
this pull request
Aug 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was begun to fix circular reference issues utils.
propUtilsimported Icon/Image for the prop renderers, however, Icon/Image also imported somepropUtils. This PR resolves circular references and splits utils into 2 categories and refactors all components.src/lib
Project specific modules that have dependencies on vendors and utils. This is our standard library.
src/factories
These were previously
propRenderers. Since they didn't actually render anything, but return JSX elements, they are actually factories. They vary fromReact.createFactoryin that they accept a wider variety of input to create an element.We now have a generic
createFactoryfunction. It returns a factory function capable of creating elements from any value except undefined, including a ReactElement. It accepts extra props and merges theclassNameprop by default. This makes them ideal our prop handling case.createIcon(),createImage())Index Files
Index files were also added to all
src/*directories. This greatly simplifies imports throughout the project.During this entire process some additional housekeeping was done.