Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): Update SemanticShorthandCollection to support Typescript 4.8 #4390

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

timduffin
Copy link
Contributor

@timduffin timduffin commented Oct 17, 2022

typescript@4.8.4 build error

73 export type SemanticShorthandCollection<TProps> = SemanticShorthandItem<TProps>[]
                                               ~~~~~~
    This type parameter might need an `extends Record<string, any>` constraint.

For completeness, here is the breaking change in question
https://devblogs.microsoft.com/typescript/announcing-typescript-4-8-beta/#breaking-changes

@welcome
Copy link

welcome bot commented Oct 17, 2022

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@iamtomcat
Copy link

Nice wanted to sort this out as well.

@timduffin
Copy link
Contributor Author

The powers that be need to update Vercel's node build version

Error: Node.js Version "12.x" is discontinued and must be upgraded. Please set Node.js Version to 16.x in your Project Settings to use Node.js 16.

@layershifter
Copy link
Member

The powers that be need to update Vercel's node build version

Error: Node.js Version "12.x" is discontinued and must be upgraded. Please set Node.js Version to 16.x in your Project Settings to use Node.js 16.

Done 👍
Will check the PR a bit later this week.

@layershifter layershifter changed the title fix:(type-checking): typescript@4.8.4 Tprops error fix(types): Update SemanticShorthandCollection to support Typescript 4.8 Oct 19, 2022
@layershifter
Copy link
Member

@timduffin thank you 👍

@layershifter layershifter merged commit c3cbcae into Semantic-Org:master Oct 19, 2022
@welcome
Copy link

welcome bot commented Oct 19, 2022

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@quanganhtran
Copy link

Could we release this fix?

@layershifter
Copy link
Member

@quanganhtran was released in semantic-ui-react@2.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants