Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel format enhancements #857

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

thomas-topway-it
Copy link
Contributor

see https://fina.knowledge.wiki/Test_Carousel

@jaideraf jaideraf added this to the 5.0.0 milestone Nov 21, 2024
@jaideraf
Copy link
Member

@thomas-topway-it the test to MW 1.39 is not passing... for SMW 5.0 release, MW 1.39 is more important than 1.35, so, if you can adjust to at least the 1.39 to pass, it will probably be merged.

@thomas-topway-it
Copy link
Contributor Author

noted, I'm sorry for the delay

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.55%. Comparing base (b40de8d) to head (afa9d54).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #857      +/-   ##
============================================
+ Coverage     45.51%   45.55%   +0.03%     
  Complexity     2320     2320              
============================================
  Files            80       80              
  Lines          9043     9049       +6     
============================================
+ Hits           4116     4122       +6     
  Misses         4927     4927              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants