-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carousel format enhancements #857
base: master
Are you sure you want to change the base?
Carousel format enhancements #857
Conversation
@thomas-topway-it the test to MW 1.39 is not passing... for SMW 5.0 release, MW 1.39 is more important than 1.35, so, if you can adjust to at least the 1.39 to pass, it will probably be merged. |
noted, I'm sorry for the delay |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #857 +/- ##
============================================
+ Coverage 45.51% 45.55% +0.03%
Complexity 2320 2320
============================================
Files 80 80
Lines 9043 9049 +6
============================================
+ Hits 4116 4122 +6
Misses 4927 4927 ☔ View full report in Codecov by Sentry. |
adaptiveHeight
if set), images are vertically centeredsee https://fina.knowledge.wiki/Test_Carousel