Fixes #1224: Show all posts for an author sorted by date when searching by Author

[joelazwar]

Issue This PR Addresses

Issue #1224

Type of Change

• Bugfix: Change which fixes an issue
• New Feature: Change which adds functionality
• Documentation Update: Change which improves documentation
• UI: Change which improves UI

Description

Changes search by author function to display the initial result (container that links to feed) and the addition of the timeline of their posts

works with with multiple persons with shared names, but is limited to max posts per page. For best results, search for author's full name.

Checklist

• Quality: This PR builds and passes our npm test and works locally
• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
• Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

[humphd]

This is really interesting. I love being able to get the posts for a user. I'm not 100% what to think about mixing the Author "card" with the results, whether it's a good thing or not.

One thing, when we fix #1260 this will maybe bee moot, since we can always show results for a specific author.

[humphd]

@joelazwar Where does this stand? At the very least we need a rebase to get the SearchPage changes in.

[joelazwar]

@humphd Right, I haven't had the time to think of a new design lately, so I'll just stick with the timeline of posts as a result. I'll go ahead and rebase this now

[joelazwar]

I rebased my branch but its practically more like a new branch I guess, since I undid all the changes (#1295 basically fixed the functionality) but I edited the query so that searched posts timeline is now sorted by date, however this is true for both author and posts filters. Let me know if you want to change that

[humphd]

So this issue is fixing "Show all posts for an author sorted by date when searching by Author" but you seem to be doing it for all filter types. Can we limit this to filter='author'?

[joelazwar]

@humphd done 189961e

[c3ho]

Searching by author doesn't work for me, did a search using incognito on Chrome, no results. Post worked though