Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change usage to avoid warnings for quanteda v3 #21

Merged
merged 2 commits into from
Mar 30, 2021

Conversation

kbenoit
Copy link
Contributor

@kbenoit kbenoit commented Mar 29, 2021

texts() is replaced by as.character() in the forthcoming quanteda v3 release. This PR updates the usage, to avoid warnings when using v3.

kbenoit and others added 2 commits March 29, 2021 22:01
@sborms sborms merged commit 73b067b into SentometricsResearch:master Mar 30, 2021
@sborms
Copy link
Collaborator

sborms commented Mar 30, 2021

Thanks Ken! Happy you are willing to do the efforts to keep dependent packages in check.

@kbenoit
Copy link
Contributor Author

kbenoit commented Mar 30, 2021

We try! Getting v3 out is proving complicated, but happy that there's one less package to break now.

@kbenoit kbenoit deleted the fix-quanteda-v3 branch March 30, 2021 10:07
odelmarcelle pushed a commit to odelmarcelle/sentometrics that referenced this pull request Apr 9, 2021
Change usage to avoid warnings for quanteda v3

Former-commit-id: 73b067b
Former-commit-id: e71d8d74917123fd360ea1ec99c337668757ab06
odelmarcelle pushed a commit to odelmarcelle/sentometrics that referenced this pull request Apr 10, 2021
Change usage to avoid warnings for quanteda v3

Former-commit-id: 73b067b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants