Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Form1.cs #12

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Update Form1.cs #12

merged 1 commit into from
Jun 30, 2024

Conversation

toasterberry
Copy link
Contributor

Added line to update "currentDAWName" on client disposal. Fixes a bug where opening, closing, and opening the same DAW again breaks rich presence functionality until DAWRPC is restarted or different DAW is opened.

Added line to update "currentDAWName" on client disposal. Fixes a bug where opening, closing, and opening the same DAW again breaks rich presence functionality until DAWRPC is restarted or different DAW is opened.
@Serena1432
Copy link
Owner

Serena1432 commented Jun 24, 2024

You said in the PR that you "fixed a bug where opening, closing, and opening the same DAW again breaks rich presence functionality until DAWRPC is restarted or different DAW is opened", but I couldn't see anything related to that bug in your commits. Did you forget to push any commits or did you have another reason?

image

@toasterberry
Copy link
Contributor Author

Yes, I just added "currentDAWName = DAWName.Text;", that one line was enough to fix the bug.

I believe the bug happened because when previously disposing the client/closing the DAW, "currentDAWName" never got updated to reflect the DAW being closed at any point. So when trying to open a DAW (Ableton in my test) multiple times in a row, I don't think it could triggered line 362 in this file past the first time. Adding this line to update "currentDAWName" upon client disposal allows 362 to trigger every time opening the same DAW repeatedly.

@Serena1432 Serena1432 merged commit 939fd60 into Serena1432:main Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants