LibJVM: Start parsing class files #11500
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ClassFileParser
is able to parse simple classfiles into aClassFile
structure.The parser successfully consumes the .class file of the most basic Java program:
There is still a lot missing but I want to have this overall structure reviewed before I flesh out the parser and start using the ClassFile interface in the Runtime.
I'm new to modern C++ so there's probably lots to improve.
One design decision I made, is that the ClassFile structure holds onto the buffer containing the contents of the
.class
file. This is because fields of the ClassFile structure point into the buffer e.g. for strings or bytecode.Another design decision is using
unions
instead of inheritance to represent constants in the java constant pool.