LibJS: Implement %IteratorHelperPrototype%.return #20057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missing its Base invocation. But since this override is not doing anything anyways, just remove it.
This optional parameter is not currently set by any caller, but will be for the Iterator Helpers proposal. In all specs, this parameter is a static string, so we can just use a StringView rather than allocating a (Deprecated)String on each invocation. This also changes this optional parameter to be passed by const-ref, as it does not need to be copied.
In the Iterator Helpers proposal, we must create a generator object with additional internal slots and behavior differences. GeneratorObject is currently implemented assuming it wraps around an ECMAScriptFunctionObject with generated bytecode. In this proposal, we instead have "Abstract Closure" blocks. So this marks the `execute` method as virtual, to allow the future subclass to essentially just invoke those closures. We will also require mutable access to the [[GeneratorState]] internal slot.
This is required for %IteratorHelperPrototype%.return, which needs to operate on the internal slots of the base GeneratorObject. Doing so also provides us with the appropriate VM to be used in invocations to the overridden IteratorHelper::execute.
This is in preparation of implementing %IteratorHelperPrototype%.return. That will invoke GeneratorResumeAbrupt, which will execute the generator with an abrupt completion. At that time, we must take care to close the current inner iterator.
github-actions
bot
added
the
👀 pr-needs-review
trflynn89
force-pushed
the
iterator_helpers_return
branch
from
74252f9
to
50ef514
Compare
github-actions
bot
removed
the
👀 pr-needs-review
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last piece of the Iterator Helpers proposal.