Cherry-pick 1.416666 ladybird PRs #25475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were only looking at the current top-level navigable and its children when searching for the specified window handle. We need to search *all* known navigables if the handle belongs to a window not in the current tree. (cherry picked from commit 47e9357243c5e561576d03ed8d1c444076847272)
Attributes have a max value length of 1024. So we theoretically need to
support values in the range -${"9".repeat(1023)} to ${"9".repeat(1024)}.
These obviously do not fit in an i64, so we were previously failing to
parse the attribute.
We will now cap the parsed value to the numeric limits of an i64, after
ensuring that the attribute value is indeed a number.
(cherry picked from commit ba1189cd1c47ab0593e0c3d7eee85e7aafc3462d)
We were missing this spec step when parsing the Path attribute. (cherry picked from commit e74d2b17620b1d68d66d51a13831ee1657154a1c)
This case was missed in commit b5aa8f65b168c668e41ce61c966dae8198e233ed. (cherry picked from commit 969361abdb73dce664933d0250ab90ed668bc0b6)
We are currently trying to access the current parent and top-level browsing contexts from the current BC itself. However, if the current BC is closed, its association to the parent and top-level BCs is lost, and we are no longer able to handle WebDriver endpoints involving those BCs. Instead, let's store the parent and top-level BCs separately, and update them in accordance with the spec. (cherry picked from commit ab3cfd9bbb3d572d2e1ce4337e112d10ac0e94a3)
This avoids a crash seen in WPT when a click event is fired on a BC that has been removed from the document. (cherry picked from commit 95bf6c98779bbb879b19319884389148e8cd2fd2)
(cherry picked from commit 5aa50bff8b2b82c34cfaa09de32f3162d36b2a24)
(cherry picked from commit 84df1bf585de217ccf3399e31708af96c95bb9fe)
This happens when window.close() is invoked immediately upon a window being opened. (cherry picked from commit ce11a907263670a326ccb4a9625bfeaa65dac937)
github-actions
bot
added
the
👀 pr-needs-review
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LadybirdBrowser/ladybird#1434 all but first commit
LadybirdBrowser/ladybird#1644 all but 5th (got reverted) and last two (don't apply yet) commits