Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly show minutes in day view #336

Merged
merged 1 commit into from Jul 16, 2014
Merged

correctly show minutes in day view #336

merged 1 commit into from Jul 16, 2014

Conversation

ghost
Copy link

@ghost ghost commented Jul 6, 2014

No description provided.

@ghost ghost mentioned this pull request Jul 6, 2014
@dougwo
Copy link

dougwo commented Jul 8, 2014

I temporarily fixed this as follows:

calendar.js line 534:

from
var m = "" + (time_split * part + (hour == 0) ? parseInt(time_start[1]) : 0);

to
var m = "" + (time_split * part);

I don't know what the last part was for, but it was confusing... This may have wider-reaching implications

@geskill
Copy link
Contributor

geskill commented Jul 9, 2014

the last part:

((hour == 0) ? parseInt(time_start[1]) : 0))

this is for setting the start time considering minutes, too. minutes ll be added to the first hours.

example:
start_time: 07:30
time_split: 30

then my calendar starts with: 07:30 and 08:00 is the next row.

@dougwo
Copy link

dougwo commented Jul 9, 2014

Well it doesn't work. Look at the demo page! It just repeats the hour and no minutes...

@geskill
Copy link
Contributor

geskill commented Jul 9, 2014

because brackets are missing ...

(hour == 0) ? parseInt(time_start[1]) : 0)

fix it to the following and it works ... therefore i said, this patch is needed (see here: #335)

((hour == 0) ? parseInt(time_start[1]) : 0))

@dougwo
Copy link

dougwo commented Jul 10, 2014

Ah. I missed that at first. thanks!

@ghost
Copy link
Author

ghost commented Jul 10, 2014

Any reason this hasn't been merged yet?

@josh-m-sharpe
Copy link

bump.

eleazan added a commit that referenced this pull request Jul 16, 2014
@eleazan eleazan merged commit eb01aea into Serhioromano:master Jul 16, 2014
@Serhioromano
Copy link
Owner

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants