-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ParseOptions: Add read_tags
#251
Comments
hello, it would be great to be able to do |
@vincehi Hello! There wouldn't need to be a feature for this. Since |
Does this seem complicated to you? I preferred to use taglib even though it also analyses tags even though I don't need it, but it doesn't crash on the file format (UTF-...). On the other hand, the length recovered is in milisecond on lofty, which is very convenient for me. |
No, it'd be a pretty quick feature to add. I just haven't bothered since I've been working on more requested features.
Can you make issues for any crashes you have with Lofty? There haven't been any text encoding issues that I'm aware of. |
I think I had the same problem as this person #373. But if I understand correctly, it's on the read tags, not on the read properties. So if in future I could bypass the read tags that would be great. |
Yeah, this would avoid the error in #373 entirely. I'll see about getting this in 0.21.0. |
This makes it possible to use Lofty exclusively for its property reading, which many projects do at this point. closes #251
Thank's for this option, it's realy fast 🚀 |
This makes it possible to use Lofty exclusively for its property reading, which many projects do at this point. closes #251
Summary
Unexpectedly, many projects pull in Lofty solely for its property reading. Each time it is used for this purpose, however, all of the tags are still being parsed unnecessarily.
Just as one can skip property reading with
ParseOptions::read_properties(false)
, it may be worth addingParseOptions::read_tags()
.API design
The text was updated successfully, but these errors were encountered: