Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Waiting for git blame response" (5.0.1) #92

Closed
dominikzogg opened this issue Oct 14, 2020 · 4 comments
Closed

"Waiting for git blame response" (5.0.1) #92

dominikzogg opened this issue Oct 14, 2020 · 4 comments
Assignees
Labels

Comments

@dominikzogg
Copy link

dominikzogg commented Oct 14, 2020

The Version 5.0.1 broke the extension for me (it successfully show the committer, but click on it shows "Waiting for git blame response" instead of opening a notification with a link to github (in my case)

Within console i get:

mainThreadExtensionService.ts:65 [[object Object]]Invalid URL: git@github.com:account/project.git
$onExtensionRuntimeError @ terminalInstanceService.ts:31
_doInvokeHandler @ rpcProtocol.ts:401
_invokeHandler @ rpcProtocol.ts:332
_receiveRequest @ rpcProtocol.ts:278
_receiveOneMessage @ rpcProtocol.ts:220
(anonymous) @ rpcProtocol.ts:93
fire @ event.ts:535
fire @ ipc.net.ts:407
_receiveMessage @ ipc.net.ts:755
(anonymous) @ ipc.net.ts:630
fire @ event.ts:535
acceptChunk @ ipc.net.ts:224
(anonymous) @ ipc.net.ts:149
t @ ipc.net.ts:892
emit @ events.js:223
addChunk @ _stream_readable.js:309
readableAddChunk @ _stream_readable.js:290
Readable.push @ _stream_readable.js:224
onStreamRead @ internal/stream_base_commons.js:181
mainThreadExtensionService.ts:66 TypeError [ERR_INVALID_URL]: Invalid URL: git@github.com:account/project.git
	at onParseError (internal/url.js:243)
	at new URL (internal/url.js:319)
	at _ (/path/to/extension/waderyan.gitblame-5.0.1/dist/index.js:57)
	at q (/path/to/extension/waderyan.gitblame-5.0.1/dist/index.js:67)
	at processTicksAndRejections (internal/process/task_queues.js:94)
	at async W.showMessage (/path/to/extension/waderyan.gitblame-5.0.1/dist/index.js:78)

My guess, the change works only with http(s) but not with ssh.

@shelmire
Copy link

Same here.

@Sertion
Copy link
Owner

Sertion commented Oct 14, 2020

Hey Dominik and Alex!

Thank you for the report and for the stack trace!
I will look into this immediately.

@Sertion Sertion added the bug label Oct 14, 2020
@Sertion Sertion self-assigned this Oct 14, 2020
Sertion added a commit that referenced this issue Oct 14, 2020
@Sertion
Copy link
Owner

Sertion commented Oct 14, 2020

I've released a new version with a fix for this issue and a few other things I was working on. Please report back with any further issues you find!

It can sometimes take a few hours before a new version gets pushed to everyone and sometimes you need to restart vscode to make it check for updated extensions.

Thanks again for the report!

@dominikzogg
Copy link
Author

@Sertion works! thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants