Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inlineBlameColor #136

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Remove inlineBlameColor #136

merged 1 commit into from
Dec 19, 2022

Conversation

razinj
Copy link

@razinj razinj commented Dec 18, 2022

As I wanted to change the color for the inline blame text, I was trying to use the supplied setting inlineBlameColor in the README, but after digging into the PR, I found out that it was removed to use a more standardized way which is the editorCodeLens.foreground setting inside the workbench.colorCustomizations object.

So, I opened this PR to remove the misleading setting from the README.

@Sertion
Copy link
Owner

Sertion commented Dec 19, 2022

Hey RAZINJ! Thank you for the PR.

I'm sorry that the documentation was incorrect. I am very grateful you took the initiative to fix it.

@Sertion Sertion merged commit 30a6ca7 into Sertion:master Dec 19, 2022
@Sertion
Copy link
Owner

Sertion commented Dec 19, 2022

A new version is being pushed.

@razinj
Copy link
Author

razinj commented Dec 19, 2022

Awesome, glad to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants