Skip to content
This repository has been archived by the owner on Jun 17, 2020. It is now read-only.

[WIP] add RealMe #194

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from
Open

[WIP] add RealMe #194

wants to merge 3 commits into from

Conversation

mermop
Copy link
Member

@mermop mermop commented Sep 11, 2019

Not actually working - getting an error about signatures on the MTS (message testing server) environment - but figured it was worth giving a quick go and putting up as a WIP

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

app/views/devise/sessions/_realme.html.erb Outdated Show resolved Hide resolved
@Br3nda Br3nda temporarily deployed to feijoa-pr-194 September 11, 2019 00:45 Inactive
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

* @param {[type]} jQuery Cache a local jQuery object.
* @return {Object} RM A public API to the RealMe widget.
*/
var RealMe = RealMe || (function(document, window, jQuery) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function RealMe has 51 lines of code (exceeds 25 allowed). Consider refactoring.

* @param {[type]} jQuery Cache a local jQuery object.
* @return {Object} RM A public API to the RealMe widget.
*/
var RealMe = RealMe || (function(document, window, jQuery) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function RealMe has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deal with it mate, it's vendor code

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants