-
Notifications
You must be signed in to change notification settings - Fork 1
[WIP] add RealMe #194
base: staging
Are you sure you want to change the base?
[WIP] add RealMe #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 You fixed the issue(s)! Great work.
* @param {[type]} jQuery Cache a local jQuery object. | ||
* @return {Object} RM A public API to the RealMe widget. | ||
*/ | ||
var RealMe = RealMe || (function(document, window, jQuery) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function RealMe
has 51 lines of code (exceeds 25 allowed). Consider refactoring.
* @param {[type]} jQuery Cache a local jQuery object. | ||
* @return {Object} RM A public API to the RealMe widget. | ||
*/ | ||
var RealMe = RealMe || (function(document, window, jQuery) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function RealMe
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deal with it mate, it's vendor code
Not actually working - getting an error about signatures on the MTS (message testing server) environment - but figured it was worth giving a quick go and putting up as a WIP