Smurty version #170
Smurty version #170
Conversation
|
|
||
|
|
||
| def get_action_post_hoc(agent: GenericAgent, step_info): | ||
| """ |
There was a problem hiding this comment.
I think this can be safely ported to the unsupervised project
There was a problem hiding this comment.
we can remove this too. This is some old stuff i was trying
There was a problem hiding this comment.
I am not sure about what these changes do. Worst case you could copy this file and run it from your laptop. We could also make changes to the main x-ray if they are generic use cases
There was a problem hiding this comment.
There were some issues with the earlier version of agentlab, which this fixes. But now, i think we can discard these
There was a problem hiding this comment.
If this is specific to your use case, we could bring this to the unsupervised project and change the import in the so that the modified file is imported
| @@ -20,6 +20,7 @@ def run_experiments( | |||
| exp_args_list: list[ExpArgs], | |||
| study_dir, | |||
| parallel_backend="joblib", | |||
| save_transition_history=False, | |||
There was a problem hiding this comment.
saving transition history should be done by placing them inside the AgentInfo. I -and @ThibaultLSDC - can help you figure this out :)
| except FileNotFoundError: | ||
| yield exp_result.exp_args | ||
| # yield exp_result.exp_args | ||
| try: | ||
| yield exp_result.exp_args | ||
| except Exception as e: | ||
| logging.error(f"Error with exp_result.exp_args: {e}") |
There was a problem hiding this comment.
This is not needed
| def run( | ||
| self, | ||
| n_jobs=1, | ||
| parallel_backend="joblib", | ||
| strict_reproducibility=False, | ||
| ): | ||
| """Run all experiments in the study in parallel when possible. |
There was a problem hiding this comment.
this is just cosmetic
| run_experiments( | ||
| n_jobs, | ||
| self.exp_args_list, | ||
| self.dir, | ||
| parallel_backend=parallel_backend, | ||
| ) | ||
| report_df = self.get_report(ignore_cache=True) |
There was a problem hiding this comment.
just cosmetic
There was a problem hiding this comment.
@ThibaultLSDC @recursix Would VLLMChatModels be relevant for AgentLab?
There was a problem hiding this comment.
This file has been deprecated
There was a problem hiding this comment.
Thibault made a PR to port this to AgentLab main
No description provided.