Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meaningful names for the services #14

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Add meaningful names for the services #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions adservice/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@ type Ad struct {
Text string // Short advertisement text to display.
}

type T interface {
type AdService interface {
GetAds(ctx context.Context, keywords []string) ([]Ad, error)
}

type impl struct {
weaver.Implements[T]
weaver.Implements[AdService]
ads map[string]Ad
}

Expand Down
58 changes: 29 additions & 29 deletions adservice/weaver_gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions cartservice/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@ type CartItem struct {
Quantity int32
}

type T interface {
type CartService interface {
AddItem(ctx context.Context, userID string, item CartItem) error
GetCart(ctx context.Context, userID string) ([]CartItem, error)
EmptyCart(ctx context.Context, userID string) error
}

type impl struct {
weaver.Implements[T]
weaver.Implements[CartService]
cache weaver.Ref[cartCache]
store *cartStore
}
Expand Down
Loading
Loading