Remove py27 py34 support #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes all test runners (e.g. tox, Travis-CI, Appveyor), and documentation. The timing tests for Python 2.7 are also removed.
This can be done in the setup.py itself.
All compatiblity code has been removed, and also the tests for builtin replacements for those python versions have been removed.
The C code has had the #IFDEFs required for Python 2.7 and Pythonm 3.4 removed so that the flow of the code is much smoother to read.
Prior to Python 3.3, it was not possible to read a boolean from PyArg_ParseTupleAndKeywords, so booleans were read as a PyObject. Now, it is possible to directly convert to boolean type on read, so this is now done where possible.
SethMMorton
force-pushed
the
remove-py27-py34-support
branch
from
6f1d4d5 to
9a55651
Compare
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 90.45% 91.03% +0.57%
==========================================
Files 6 6
Lines 859 825 -34
Branches 137 130 -7
==========================================
- Hits 777 751 -26
+ Misses 39 37 -2
+ Partials 43 37 -6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to close #21.