Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please use pytest-pycodestyle instead of pytest-pep8 #68

Closed
yurivict opened this issue Sep 9, 2018 · 8 comments
Closed

Please use pytest-pycodestyle instead of pytest-pep8 #68

yurivict opened this issue Sep 9, 2018 · 8 comments

Comments

@yurivict
Copy link

yurivict commented Sep 9, 2018

pep8 has been renamed to pycodestyle, along with their pytest- counterparts.

@SethMMorton
Copy link
Owner

Please make a pull request for this change.

@yurivict
Copy link
Author

yurivict commented Sep 9, 2018

Sorry, I can't. I am only a maintainer of the port.
I only tried to avoid creation of the unnecessary package.

@SethMMorton
Copy link
Owner

I don’t understand why being a maintainer of the port means you cannot create a pull request. I will accept a pull request from anyone no matter their relationship to the code. I am not asking you to be a long term contributor.

@yurivict
Copy link
Author

yurivict commented Sep 9, 2018

I have no resources to fix issues in individual projects. I also have no idea what pep8 is for. So I would have to learn first what is it for, and this isn't going to be cost effective compared to this being done by someone who added pep8 there in the first place.

@SethMMorton
Copy link
Owner

I will make this change because your reasoning sounds valid.

Some free advice

Please keep in mind that like yourself, the developers of the libraries and tools that you are creating ports for do so in their spare time. If there is a bug, a developer fully expects that it is on them to investigate and fix the bug. However, when someone asks for a specific change that does not actually fix a bug and does not provide a new feature, there is often an expectation that the asker will contribute at least some of the work; if one just says "change this thing" without offering to help then it comes across like the developer owes the asker something or that the developer is working for the asker, both of which can lead to negative feelings.

I understand why there was no accompanying PR with this issue. In the future, things could go a bit more smoothly if instead of just pointing out the problem (which comes across as complaining) an explanation of the situation could be added -- something like the following:

Hi, can you please change <this> to <that> since <this> has been deprecated in favor of
<that>. I would like to help, but am just the BSD port maintainer and don't actually have enough
experience with python to actually make this change.

I think that it is important for maintainers of ports/packages and developers of the libraries they package to establish good relationships with each other, and a slightly less "matter-of-fact" tone when filing issues can go long way to this end.

@SethMMorton
Copy link
Owner

It turns out that the maintainer of pytest-pycodestyle will not support Python 2.7 or Python 3.4: see henry0312/pytest-pycodestyle#36 for details. Since natsort supports these versions, it will become an unnecessary hardship to use pytest-pep8 for those versions and then pytest-pycodestyle for the newer versions. Until either a) natsort drop support for those versions or b) pytest-codestyle adds support, I will continue to use pytest-pep8.

@yurivict
Copy link
Author

yurivict commented Sep 9, 2018

Ok, this is totally fine.

Thanks!

@SethMMorton
Copy link
Owner

What I think I will do is use pycodestyle directly instead of using pytest-pycodestyle. This will get rid of the old pep8 module while using something that works for the versions natsort supports.

SethMMorton added a commit that referenced this issue Sep 10, 2018
Rather than doing style and quality checking on every python version,
it will be done once in one version. More checks will be added, and
flake8 will be the driver (because of its plugins).

This will close issue #68.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants