Add ability to sort numbers after non-numbers #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for adding a few new versions of the null string, one which will be sorted after other strings, and another pair which will be used when locale is not enabled.
All infrastructure has been added, but no tests have been yet been inserted to verify that the code is working properly. That will come in the next commit.
These tests verify that the option puts numbers after non-numbers.
The implementation that was used for the "always last" separator for NUMAFTER when LOCALE was turned on for non-OSX OSs was buggy. This new implementation does not rely on string value tricks, but rather implements a sentinel-based methodology to identify the "always last" separator and place it last explicitly.
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 99.63% 99.65% +0.01%
==========================================
Files 10 10
Lines 552 574 +22
==========================================
+ Hits 550 572 +22
Misses 2 2
Continue to review full report at Codecov.
|
SethMMorton
deleted the
48-feature-request-natsorted-sort-by-letters-then-numbers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #48, which requests the ability to put numbers after non-numbers, rather than before which is the default.
This was implemented by changing the string separator that is added between or in front of numbers from an empty string to a sequence of high numeric-valued characters when the new option (
ns.NUMAFTER) is requested.