Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pipenv dependency #86

Merged
merged 3 commits into from
Nov 19, 2018
Merged

Remove pipenv dependency #86

merged 3 commits into from
Nov 19, 2018

Conversation

SethMMorton
Copy link
Owner

pipenv was added a development tool to natsort because I got caught up in all the hype. Turns out, for developing libraries pipenv offers almost no benefit over just defining a requirements.txt for your dependencies. So, I am removing pipenv as a dependency.

For people who are using tox, there will be no observable change. For people not using tox but just building natsort (and not running tests) there will be no observable change. This will only affect users who are runningnatsort tests outside of tox. For those users, they will just change from

$ pip install pipenv
$ pipenv install --dev --skip-lock
$ pipenv run python -m pytest

to

$ pip install -r dev-requirements.txt
$ python -m pytest

Much simpler! It also lets the user dictate how they handle virtual environments.

@codecov
Copy link

codecov bot commented Nov 18, 2018

Codecov Report

Merging #86 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          12       12           
  Lines         623      623           
=======================================
  Hits          620      620           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e18c469...3b6b694. Read the comment docs.

So, using pipenv is a COMPLETE waste of time for libraries. I had gotten
caught up in the hype and decided to try to use pipenv for natsort.
Turns out I was just adding a needless dependency for developers.
@SethMMorton SethMMorton force-pushed the remove-pipenv-dependency branch from ea02797 to 3b6b694 Compare November 19, 2018 02:36
@SethMMorton SethMMorton merged commit 717f995 into master Nov 19, 2018
@SethMMorton SethMMorton deleted the remove-pipenv-dependency branch November 19, 2018 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant