Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kick): emote menu button #1010

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

pimothyxd
Copy link
Contributor

@pimothyxd pimothyxd commented Mar 1, 2024

Proposed changes

A simple UI update by Kick changed the chat input container where the emote picker icon was being placed. This PR simply updates it to the new one.

Additionally, the previous implementation never reset the channel state after leaving a channel. So re-entering the same channel (e.g. by going to the homepage and back) would cause the emote picker to also not rerender. Along with that change, if no message was dispatched by the room it would also cause the channel to never be assigned. These are both fixed by this PR.

Types of changes

What types of changes does your code introduce to 7TV?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

A snippet of what it was before:

logged_in

and after:

logged_in

@pimothyxd pimothyxd changed the base branch from master to feat/bug-fixes March 1, 2024 03:31
@ozknozsrt
Copy link

related issue #1008

@TroyKomodo TroyKomodo merged commit cbf2607 into SevenTV:feat/bug-fixes Mar 4, 2024
5 checks passed
@pimothyxd pimothyxd deleted the fix/kick-emote-menu branch March 10, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants