Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Animated FFZ emote support #1051

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

ChrisScr3ams
Copy link

Proposed changes

Only static FFZ emotes are currently supported by 7TV. For animated emotes only the static version is used, probably because FFZ itself only added support for them rather recently. Because of that 7TV should add support for animated FFZ emotes as well.

Types of changes

What types of changes does your code introduce to 7TV?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

The FFZ API has a field "animated" which returns a map of DPI scales to animated emote URLs and is null if the emote is not animated. This field was added to our interface and the transformer adjusted to use the correct url and file dependant on if the emote is animated or not.

Documentation from FFZ API:
Screenshot 2024-06-20 203722

@Excellify
Copy link
Collaborator

Mind switching changelog version to 3.1.1.3000 and dev version to 3.0?

@Excellify Excellify merged commit 229d8cb into SevenTV:dev Jun 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants