Feat: added support for pop-out and embedded chats. #1053
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When viewing a Twitch chat that is using a Twitch chat embed url (
https://www.twitch.tv/embed/<channel>/chat?
) or a popout chat url (https://www.twitch.tv/popout/<channel>/chat
), the 7TV extension will not load or work because it is only allowed to access top-level windows.This is a simple fix that enables
"all_frames": true
in the manifest and then adds checks to see if the current window is a regular top-level window or a chat pop-out or embed.This solves the following issues: #916 #844 #187
Types of changes
What types of changes does your code introduce to 7TV?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, you may want to start the discussion by explaining why you chose the solution you did, what alternatives you considered, etc.