Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Highlighting by username and badges #1054

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from

Conversation

ChrisScr3ams
Copy link

@ChrisScr3ams ChrisScr3ams commented Jul 11, 2024

Proposed changes

At the moment users were only able to highlight certain phrases in chat messages. They should be able to highlight also dependant on user and badges.
Feature Request: #1027

Types of changes

What types of changes does your code introduce to 7TV?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Basically 2 new features were added.

  1. Highlighting by username: The users can provide a username. If a chatmessage has an author with that name it is highlighted. Since regex and case sensitivity don't really make sense for usernames I removes the options for those.
    image
    Additionally a button was added to user cards to quickly toggle highlighting for the user.
    image

  2. Highlighting by badge: The user can select a badge from a list and all users with this badge have their messages highlighted.
    The list of badges is grabbed directly from twitch, so no manual changes have to be made when badges are added or removed.
    image

For a future update it could make sense to also add a way to change priority of highlights (for cases where messages fit multiple highlighting settings). At the moment the highlight which was created last has the highest priority, regardless of which kind of highlight it is.
Another idea for teh future could be adding 3rd party badges to the list for highlighting.

@ChrisScr3ams ChrisScr3ams changed the title Feat/highlight by username Feat: Highlighting by username and badges Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant