Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main nav accessibility improvements #703

Closed
wants to merge 2 commits into from

Conversation

acdvs
Copy link

@acdvs acdvs commented Sep 27, 2022

Improves the accessibility of the main nav.

  • Basic keyboard navigation
  • Screen reader-friendly labeling

The Tooltip component now passes its generated unique label for use by any child element that needs to attach it (e.g., for aria-labelledby).

Ideally, the entire header nav needs to be restructured to make better use of semantic HTML and to standardize button structure, but I didn't want to interfere with any styling for this PR.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@acdvs acdvs closed this by deleting the head repository Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants