Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use correct openssl location #279

Merged
merged 5 commits into from
Oct 3, 2024
Merged

Conversation

Nerixyz
Copy link
Collaborator

@Nerixyz Nerixyz commented Oct 3, 2024

Fixes #278.

@LosFarmosCTL
Copy link

Looks like the arm64 part of the binary links to the absolute homebrew paths, while x86 correctly uses the framework folder relative to the execution path. Not exactly sure what causes that to happen though:

SCR-20241003-pubs

@Nerixyz
Copy link
Collaborator Author

Nerixyz commented Oct 3, 2024

@LosFarmosCTL could you try the universal build from this PR? https://github.com/SevenTV/chatterino7/actions/runs/11166845955?pr=279

@LosFarmosCTL
Copy link

Yup, it works again using the substitution.

Still no idea why it's not getting set correctly in the first place, I tried poking around locally the last two hours but couldn't find any fix. The macdeployqt call in .CI/MacDeploy.sh doesn't rewrite the paths correctly, but why it's only an issue for specifically libssl in the arm64 part is beyond me, since everything else does get set correctly. Looks like changing the install name afterwards is the best fix for the moment.

@Nerixyz
Copy link
Collaborator Author

Nerixyz commented Oct 3, 2024

Thank you! As far as I know, pajlada only used the fixes I had before this PR (for rewriting libssl's search paths), not sure why more adjustments are required now. I'm hoping Chatterino2 can use this in the future as well (would make the release process a bit more "open").

@Nerixyz Nerixyz marked this pull request as ready for review October 3, 2024 18:38
@Nerixyz Nerixyz enabled auto-merge (squash) October 3, 2024 18:38
@Nerixyz Nerixyz merged commit 19b4ba7 into SevenTV:chatterino7 Oct 3, 2024
15 checks passed
@Nerixyz Nerixyz deleted the fix/mac-again branch October 3, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS Universal binary doesn't properly include openssl dependency
2 participants