Skip to content

Commit

Permalink
v.checker: disallow assigning none to _ (vlang#20646)
Browse files Browse the repository at this point in the history
  • Loading branch information
pierrec authored Jan 27, 2024
1 parent 91d50e4 commit 75e9065
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 0 deletions.
4 changes: 4 additions & 0 deletions vlib/v/checker/assign.v
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,10 @@ fn (mut c Checker) assign_stmt(mut node ast.AssignStmt) {
right.right.pos)
}
} else if left.kind == .blank_ident {
if !is_decl && mut right is ast.None {
c.error('cannot assign a `none` value to blank `_` identifier',
right.pos)
}
left_type = right_type
node.left_types[i] = right_type
if node.op !in [.assign, .decl_assign] {
Expand Down
12 changes: 12 additions & 0 deletions vlib/v/checker/tests/assign_blank_none_err.out
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
vlib/v/checker/tests/assign_blank_none_err.vv:2:7: error: cannot assign a `none` value to a variable
1 | fn main() {
2 | _ := none
| ~~~~
3 | _ = none
4 | }
vlib/v/checker/tests/assign_blank_none_err.vv:3:6: error: cannot assign a `none` value to blank `_` identifier
1 | fn main() {
2 | _ := none
3 | _ = none
| ~~~~
4 | }
4 changes: 4 additions & 0 deletions vlib/v/checker/tests/assign_blank_none_err.vv
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
fn main() {
_ := none
_ = none
}

0 comments on commit 75e9065

Please sign in to comment.