Fixes for simple-navigation 4 / Rails4 #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es or provide your own implementation
Using `stub` from rspec-mocks' old `:should` syntax without explicitly enabling the syntax is deprecated. Using `any_instance` from rspec-mocks' old `:should` syntax without explicitly enabling the syntax is deprecated.
|
Ping! |
|
Hi there! Any news? |
|
Up? |
|
Hi there! Is there any chance to get this merged? |
|
Up? |
1 similar comment
|
Up? |
|
can this be used with simple navigation 4? |
|
@Ved54321 yes |
|
Almost a year of waiting... are you ok? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR duplicates #12 and #13.
It fixes caret rendering and adds remove_navigation_class option.
It also fixes tests with Simple Navigation 4, RSpec new syntax and Rails 4 (html/document has been removed in Rails 4.2 and replaced by a gem rails-deprecated_sanitizer).