Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade codecov to stable v3 from v4 beta #1293

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

MohabMohie
Copy link
Contributor

No description provided.

Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #1293 (4a9b1b8) into main (0904fd7) will decrease coverage by 0.83%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1293      +/-   ##
============================================
- Coverage     50.71%   49.89%   -0.83%     
+ Complexity     1243     1221      -22     
============================================
  Files           102      102              
  Lines         10008    10008              
  Branches       1049     1049              
============================================
- Hits           5076     4993      -83     
- Misses         4300     4395      +95     
+ Partials        632      620      -12     

see 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@AhmdZanoon AhmdZanoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V3 is recommended as latest stable version rather than v4 as per codecov documentation , we need also to make sure that dependbot will not change it to v4 till its stable

@AhmdZanoon AhmdZanoon merged commit c4035b4 into main Sep 25, 2023
26 of 27 checks passed
@AhmdZanoon AhmdZanoon deleted the Codecov-v3-downgrade branch September 25, 2023 17:51
AhmdZanoon added a commit that referenced this pull request Sep 25, 2023
* Bump io.netty:netty-handler from 4.1.97.Final to 4.1.98.Final (#1291)

Bumps [io.netty:netty-handler](https://github.com/netty/netty) from 4.1.97.Final to 4.1.98.Final.
- [Commits](netty/netty@netty-4.1.97.Final...netty-4.1.98.Final)

---
updated-dependencies:
- dependency-name: io.netty:netty-handler
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Downgrade codecov to stable v3 from v4 beta (#1293)

Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
MohabMohie added a commit that referenced this pull request Sep 26, 2023
* update pom.xml

* Update pom.xml

* Update pom.xml

* Update pom.xml

* Update pom.xml

* Update pom.xml

* update e2eTests.yml

update codecov version

* Revert "update e2eTests.yml"

This reverts commit 036333d.

* Updating branch with main latest (#1294)

* Bump io.netty:netty-handler from 4.1.97.Final to 4.1.98.Final (#1291)

Bumps [io.netty:netty-handler](https://github.com/netty/netty) from 4.1.97.Final to 4.1.98.Final.
- [Commits](netty/netty@netty-4.1.97.Final...netty-4.1.98.Final)

---
updated-dependencies:
- dependency-name: io.netty:netty-handler
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Downgrade codecov to stable v3 from v4 beta (#1293)

Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
Co-authored-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants