Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtual threading #1318

Merged
merged 6 commits into from
Oct 7, 2023
Merged

Virtual threading #1318

merged 6 commits into from
Oct 7, 2023

Conversation

MohabMohie
Copy link
Contributor

No description provided.

MohabMohie and others added 5 commits October 8, 2023 00:56
@MohabMohie
removing
6407847 
- synchronized methods
- support for method-level testng parallelization (unused feature)
- threadlocal webdriver

Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
@MohabMohie
experimenting with multi-virtual-threads
4153850 
- split the element identification core to 6 CORE blocks. TODO: extract them to separate methods and form a class around them.
- used 1 service virtual thread, then 5 parallel services over virtual threads, then synchronized to perform sequential element action.
- this major enhancements should achieve better CPU utilization and show impact at a larger scale.

Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
@MohabMohie
upgrading pipelines JDK to 21
301f283 
Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
@MohabMohie
upgrading pipelines maven to 3.9.5
ea92a15 
Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
@MohabMohie
upgrading pipelines jacoco to 0.8.10
61ddb78 
Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
@codecov
Copy link

codecov bot commented Oct 7, 2023 •
edited
Loading

Codecov Report

Merging #1318 (7386ef9) into main (126ffec) will decrease coverage by 16.06%.
Report is 3 commits behind head on main.
The diff coverage is 29.72%.

@@              Coverage Diff              @@
##               main    #1318       +/-   ##
=============================================
- Coverage     50.91%   34.86%   -16.06%     
+ Complexity     1255      811      -444     
=============================================
  Files           102      102               
  Lines         10034    10068       +34     
  Branches       1051     1049        -2     
=============================================
- Hits           5109     3510     -1599     
- Misses         4288     5977     +1689     
+ Partials        637      581       -56
Files Coverage Δ
...ft/gui/browser/internal/JavaScriptWaitManager.java 45.78% <100.00%> (-12.05%) ⬇️
...om/shaft/gui/internal/image/ScreenshotManager.java 32.58% <100.00%> (-5.16%) ⬇️
...om/shaft/listeners/CucumberTestRunnerListener.java 73.21% <100.00%> (-5.48%) ⬇️
.../shaft/listeners/internal/JunitListenerHelper.java 0.00% <ø> (ø)
...shaft/listeners/internal/TestNGListenerHelper.java 44.88% <ø> (-16.48%) ⬇️
.../shaft/validation/internal/ValidationsBuilder.java 76.00% <100.00%> (-24.00%) ⬇️
...c/main/java/com/shaft/listeners/JunitListener.java 0.00% <0.00%> (ø)
...performance/internal/LightHouseGenerateReport.java 0.00% <0.00%> (ø)
...shaft/properties/internal/PropertyFileManager.java 62.50% <0.00%> (-2.09%) ⬇️
...ft/driver/internal/AppiumSelfManagementHelper.java 0.00% <0.00%> (ø)
... and 14 more

... and 48 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MohabMohie
handling failure inside a virtual thread
7386ef9 
Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
@MohabMohie MohabMohie merged commit a2c9e2e into main Oct 7, 2023
21 of 25 checks passed
@MohabMohie MohabMohie deleted the virtual-threading branch October 7, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MohabMohie