Feature/add dynamic path param support #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1808 +/- ##
============================================
- Coverage 53.24% 52.48% -0.76%
- Complexity 1355 1357 +2
============================================
Files 113 115 +2
Lines 10176 10359 +183
Branches 991 1000 +9
============================================
+ Hits 5418 5437 +19
- Misses 4117 4281 +164
Partials 641 641 ☔ View full report in Codecov by Sentry. |
added 9 commits
November 30, 2024 00:24
MahmoudElSharkawy
requested changes
Dec 12, 2024
| .setTargetStatusCode(200) // Expected status code | ||
| .perform(); // Execute the request | ||
|
|
||
| SHAFT.Report.log(">>>>>> Response Body:" + api.getResponseBody()); |
There was a problem hiding this comment.
please add assertion to validate the response.
| .setTargetStatusCode(200) | ||
| .perform(); | ||
|
|
||
| SHAFT.Report.log(">>>>>> Response Body:" + api.getResponseBody()); |
There was a problem hiding this comment.
please add assertion to validate the response.
| .setTargetStatusCode(200) | ||
| .perform(); | ||
|
|
||
| SHAFT.Report.log("Response Body: " + api.getResponseBody()); |
There was a problem hiding this comment.
please add assertion to validate the response.
MahmoudElSharkawy
requested changes
Dec 12, 2024
| .setTargetStatusCode(200) | ||
| .perform(); | ||
|
|
||
| api.assertThatResponse().body().contains("\"username\":\"string\""); |
There was a problem hiding this comment.
Suggested change
| api.assertThatResponse().body().contains("\"username\":\"string\""); | |
| api.assertThatResponse().extractedJsonValue("username").isEqualTo("string"); |
| .setTargetStatusCode(200) | ||
| .perform(); | ||
|
|
||
| api.assertThatResponse().body().contains("\"username\":\"string\""); |
There was a problem hiding this comment.
Suggested change
| api.assertThatResponse().body().contains("\"username\":\"string\""); | |
| api.assertThatResponse().extractedJsonValue("username").isEqualTo("string"); |
| .setTargetStatusCode(200) | ||
| .perform(); | ||
|
|
||
| api.assertThatResponse().body().contains("\"username\":\"string\""); |
There was a problem hiding this comment.
Suggested change
| api.assertThatResponse().body().contains("\"username\":\"string\""); | |
| api.assertThatResponse().extractedJsonValue("username").isEqualTo("string"); |
MahmoudElSharkawy
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update enhances the RequestBuilder class by introducing dynamic path parameter substitution. The solution includes: