Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced Action Logging for Typing Actions #1824

Closed

Conversation

KyrillosNageh
Copy link
Contributor

@KyrillosNageh KyrillosNageh commented Dec 9, 2024

This pull request enhances the logging for typing actions to include:

  • The data being typed (e.g., "SHAFT_Engine").
  • The target element's placeholder (e.g., [بحث]).

The log format now appears as:
[INFO] Type "SHAFT_Engine" into [بحث] element

Fixes #1799

@KyrillosNageh KyrillosNageh marked this pull request as draft December 9, 2024 19:58
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 52.50%. Comparing base (ce02a45) to head (ed7c068).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
src/main/java/com/shaft/api/RequestBuilder.java 75.00% 2 Missing and 2 partials ⚠️
...n/java/com/shaft/gui/element/internal/Actions.java 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1824      +/-   ##
============================================
- Coverage     53.24%   52.50%   -0.74%     
  Complexity     1355     1355              
============================================
  Files           113      115       +2     
  Lines         10176    10362     +186     
  Branches        991     1000       +9     
============================================
+ Hits           5418     5441      +23     
- Misses         4117     4281     +164     
+ Partials        641      640       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KyrillosNageh KyrillosNageh deleted the enhance-action-logging branch December 9, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhance action logging
1 participant