Fix 4 variable errors in xlsx.js #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- QUOTE at line 21524 - _hashIndex at line 21603 - _listIndex at line 21604 - style_builder at line 20830
|
Unless this merges, the app will crash. |
|
merging this pr will close this issue #17. A quick fix is to create a patch with your fixes within your project |
|
OMG how is this still open? |
Sadly the repo has been dead since late 2021, however there’s I’ve forked the repo so you can use that |
hah ok thanks for the quick reply :) i managed to get my code to work using the xlsx package, so no worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following undefined variables in xlsx.js:
Fixes the following (closed) issues: #7 & #13
I know this repository has not been updated since November 2021, however creating a PR seems like the right thing to do.