Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor student homework logic #1650

Merged
merged 28 commits into from
May 28, 2024
Merged

Refactor student homework logic #1650

merged 28 commits into from
May 28, 2024

Conversation

Jonas-Sander
Copy link
Collaborator

@Jonas-Sander Jonas-Sander commented May 27, 2024 •
edited
Loading

I made the code less complex and changed List to IList everywhere. This is a step to using (parts of) the logic for parents and teachers.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 81e8e96):

https://sharezone-console-dev--pr1650-hw-refactoring-nr4ncgyb.web.app

(expires Fri, 31 May 2024 17:43:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 471536afe3f6ec4895d9ea75513730b515d17eb6

@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 81e8e96):

https://sharezone-website-dev--pr1650-hw-refactoring-d43jc5lc.web.app

(expires Fri, 31 May 2024 17:43:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e

@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 81e8e96):

https://sharezone-test--pr1650-hw-refactoring-hhdefm27.web.app

(expires Fri, 31 May 2024 17:45:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@github-actions github-actions bot added the dependencies Changing, updating, adding or removing one or more dependencies. label May 28, 2024
@Jonas-Sander Jonas-Sander marked this pull request as ready for review May 28, 2024 17:40
nilsreichardt
nilsreichardt approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Nice, LGTM

@Jonas-Sander Jonas-Sander added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit d82db13 May 28, 2024
63 of 64 checks passed
@Jonas-Sander Jonas-Sander deleted the hw-refactoring branch May 28, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsreichardt nilsreichardt nilsreichardt approved these changes

Assignees
No one assigned
Labels
dependencies Changing, updating, adding or removing one or more dependencies. feature: homework testing user: pupil / student user: teacher
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jonas-Sander @nilsreichardt