Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typings declaration and add example in typescript #21

Merged
merged 3 commits into from
Oct 17, 2020

Conversation

ikr4-m
Copy link
Contributor

@ikr4-m ikr4-m commented Oct 16, 2020

I was make a bot Discord using TypeScript language, and this typings for package didn't recognize in my Text Editor (i using Visual Studio Code). So, I tried to help fix this package by fixing the existing typing so that a Text Editor like Visual Studio Code can recognize this package well.

@lgtm-com
Copy link

lgtm-com bot commented Oct 16, 2020

This pull request fixes 3 alerts when merging 279baba into a35b002 - view on LGTM.com

fixed alerts:

  • 3 for Ineffective parameter type

@lgtm-com
Copy link

lgtm-com bot commented Oct 16, 2020

This pull request fixes 3 alerts when merging 06e17d7 into a35b002 - view on LGTM.com

fixed alerts:

  • 3 for Ineffective parameter type

@Shashank3736
Copy link
Owner

You tested typings now after these changes

@ikr4-m
Copy link
Contributor Author

ikr4-m commented Oct 16, 2020

image
Yeah, i've just test it and it works.

For example, if you highlight some property with your mouse, you'll get some information about what does property use from this library.

@Shashank3736
Copy link
Owner

Thx for your contribution in typings/doc.

@Shashank3736 Shashank3736 merged commit 201e1ea into Shashank3736:master Oct 17, 2020
@Shashank3736
Copy link
Owner

@all-contributors please add @skymunn for doc and code

@allcontributors
Copy link
Contributor

@Shashank3736

I've put up a pull request to add @skymunn! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants