Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit album information to Last.fm when scrobbling #37

Closed
neilmenon opened this issue Nov 4, 2021 · 3 comments · Fixed by #38
Closed

Submit album information to Last.fm when scrobbling #37

neilmenon opened this issue Nov 4, 2021 · 3 comments · Fixed by #38

Comments

@neilmenon
Copy link
Contributor

Shazam Scrobbler is excellent, but one thing it is lacking is not submitting the album of the song to Last.fm with the scrobble. I know Shazam probably doesn't provide this information since a song doesn't need to be tied to an album, but I noticed that when a song is scrobbled on the Shazam app, an Apple Music link is provided:
image

That Apple music link could be scraped to determine the album title, which in turn could be submitted to the Last.fm API when the track is scrobbled.

The reason this is important is because, although in Last.fm the scrobbled song counts towards artist scrobbles and individual track scrobbles, it does not bump your album scrobbles of that track.

Thanks!

@stephanebruckert
Copy link
Member

Hey, glad you find the app useful and thanks for the improvement idea!

Looks like the album is available as part of the ZSHMETADATAMO sqlite table stored by Shazam.app, so that's doable without scraping the apple music link. 👍

Screenshot 2021-11-05 at 16 51 59

It would be about enhancing this query to also fetch the album name:

https://github.com/ShazamScrobbler/shazamscrobbler-macos/blob/da005241aed6e14ca119fd617667cd1caba15b9e/ShazamScrobbler/ShazamController.m#L170

and pass it here filling in onAlbum:

https://github.com/ShazamScrobbler/shazamscrobbler-macos/blob/da005241aed6e14ca119fd617667cd1caba15b9e/ShazamScrobbler/LastFmController.m#L135

I can't promise I will have time to do the fix soon, so if you or anyone else wants to have a quick go at it that would be amazing!

neilmenon added a commit to neilmenon/shazamscrobbler-macos that referenced this issue Nov 6, 2021
@neilmenon
Copy link
Contributor Author

@stephanebruckert - awesome... created PR for this enhancement. Not sure how to build on my own, but please test and let me know if it works!

#38

@stephanebruckert stephanebruckert linked a pull request Nov 7, 2021 that will close this issue
stephanebruckert added a commit that referenced this issue Nov 7, 2021
* scrape album info for scrobbles (#37)

* Simplify all queries

* Update changelog

Co-authored-by: Stephane Bruckert <stephane.bruckert@gmail.com>
@stephanebruckert
Copy link
Member

@neilmenon released in 1.3.0 https://github.com/ShazamScrobbler/shazamscrobbler-macos/releases/tag/1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants