Additional ServiceCollection extension methods #339
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These overloads allow for backwards compatibility between v3 and v4 when used inside Umbraco - allowing a v4 package to be substituted without re-compiling the entirety of Umbraco.
Reason:
Even though the new
FacetsConfig
parameter is optional and has a default value provided, existing packages that are built against v3 fail to bind to this method, producing a System.MissingMethodException:By changing the new parameter to be made available as a traditional overload instead of an optional parameter, the original method signature is kept the same and is found via reflection.