Minor Commit - 0.6.0 - 03

- Fixed Navigation Issues - Fixed Favourites List UI
Sher1234 · Jan 10, 2019 · 16a5540 · 16a5540
1 parent 6ff1eea
commit 16a5540
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -30,6 +30,7 @@ Horrible Subs uses number of open source projects to work properly:
 
 #### Release Updates
 ```
+Fixed Favourites Listing, Notification & Navigation Issues                        Minor Commit   - Jan   10, 2019
 Simplified UI with ViewModel Implementation & API Updates                         Major Commit   - Jan   09, 2019
 Added Support for HTTP Requests                                                   Minor Commit   - Oct   22, 2018
 Server moved to Hostinger (temporarily)                                           Minor Commit   - Oct   22, 2018
@@ -73,6 +74,7 @@ Currently Listing Latest 60 Releases & Reimplemented some features
 ```
 #### Todos [All Done]
 * Nyaa Implementation
+* Add Support to delete favourites from Favourites Page.
 
 #### Download
 > Head over to releases for downloading latest release/beta/alpha: [Downloads](https://github.com/Sher1234/HorribleSubs/releases)

diff --git a/app/release/app-release.apk b/app/release/app-release.apk
diff --git a/app/src/main/java/info/horriblesubs/sher/ui/common/navigation/Horrible.java b/app/src/main/java/info/horriblesubs/sher/ui/common/navigation/Horrible.java
@@ -46,8 +46,10 @@ public void onClick(View v) {
         navView.setNavigationItemSelectedListener(this);
         this.activity = activity;
 
+        if (activity instanceof Favourites) navView.setCheckedItem(R.id.favourite);
         if (activity instanceof Schedule) navView.setCheckedItem(R.id.schedule);
         if (activity instanceof Current) navView.setCheckedItem(R.id.current);
+        if (activity instanceof Search) navView.setCheckedItem(R.id.search);
         if (activity instanceof Latest) navView.setCheckedItem(R.id.latest);
         if (activity instanceof Home) navView.setCheckedItem(R.id.home);
         if (activity instanceof All) navView.setCheckedItem(R.id.all);

diff --git a/app/src/main/res/layout/layout_item_horrible_4.xml b/app/src/main/res/layout/layout_item_horrible_4.xml
@@ -4,7 +4,6 @@
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
-    android:layout_gravity="center"
     android:layout_marginStart="2dp"
     android:layout_marginTop="2dp"
     android:layout_marginEnd="2dp"
@@ -35,9 +34,10 @@
             app:cardElevation="0dp">
 
             <androidx.appcompat.widget.AppCompatImageView
-                android:id="@+id/imageView"
                 android:layout_width="match_parent"
-                android:layout_height="200dp"
+                android:layout_height="match_parent"
+                android:minHeight="210dp"
+                android:id="@+id/imageView"
                 android:scaleType="centerCrop"
                 tools:src="@tools:sample/avatars" />
 

diff --git a/app/src/main/res/layout/layout_item_horrible_4_b.xml b/app/src/main/res/layout/layout_item_horrible_4_b.xml
@@ -4,7 +4,6 @@
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="wrap_content"
     android:layout_height="wrap_content"
-    android:layout_gravity="center"
     android:layout_marginStart="2dp"
     android:layout_marginTop="4dp"
     android:layout_marginEnd="2dp"
@@ -19,7 +18,7 @@
         android:src="?attr/selectableItemBackground" />
 
     <androidx.appcompat.widget.LinearLayoutCompat
-        android:layout_width="165dp"
+        android:layout_width="170dp"
         android:layout_height="wrap_content"
         android:layout_gravity="center"
         android:orientation="vertical"
@@ -38,9 +37,10 @@
             app:cardElevation="0dp">
 
             <androidx.appcompat.widget.AppCompatImageView
+                android:layout_height="match_parent"
                 android:layout_width="match_parent"
                 android:id="@+id/imageView"
-                android:layout_height="185dp"
+                android:minHeight="185dp"
                 android:scaleType="centerCrop"
                 tools:src="@tools:sample/avatars" />