Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

add missing repo #20

Merged
merged 2 commits into from
Feb 15, 2019
Merged

add missing repo #20

merged 2 commits into from
Feb 15, 2019

Conversation

mpollmeier
Copy link
Contributor

No description provided.

@mpollmeier mpollmeier requested a review from tuxology February 2, 2019 07:45
@mpollmeier
Copy link
Contributor Author

hmm, you r review is worthless apparently - you don't have write access :)
@ml86 to the rescue!

@mpollmeier mpollmeier requested a review from ml86 February 3, 2019 19:29
Copy link
Contributor

@ml86 ml86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?
Since we want to open source this repository, it is not really a good idea to use our internal jfrog artifactory.

which doesn't have our bugfix, but is publicly hosted
intention is to open source this, so we shouldn't depend on internal
jfrog
@mpollmeier
Copy link
Contributor Author

ha, very true @ml86. changed the plugin version to the official version release, which doesn't have our bugfix (sbt/sbt-git#162), but at least it works in general. if that becomes a problem, we can publish that plugin publicly on maven central.

@fabsx00 fabsx00 self-requested a review February 15, 2019 19:57
@mpollmeier mpollmeier merged commit 19534e9 into master Feb 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the michael/jfrog branch February 15, 2019 19:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants