Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort failures appropriately #1

Closed
wants to merge 1 commit into from
Closed

fix: sort failures appropriately #1

wants to merge 1 commit into from

Conversation

panva
Copy link

@panva panva commented Feb 5, 2020

This makes sure failed items are not shown as fastest.

@ShogunPanda
Copy link
Owner

That's a good remark, thanks for noticing.
I think we can simplify this just by setting the mean of a failed items to 0 in https://github.com/ShogunPanda/cronometro/blob/master/src/index.ts#L23.
This way b.mean - a.mean holds a negative number for failed items.
What do you think?

@panva
Copy link
Author

panva commented Feb 6, 2020

Sure. Feel free to close this is you want to go the other route.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants