Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix image key and selected image #1116

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix: fix image key and selected image #1116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions src/pages/collection/series/SeriesImages.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ const sizeMap = {
Logos: { image: 'h-[clamp(15rem,_16vw,_21rem)]', grid: 'grid-cols-4' },
};

const nullImage = {} as ImageType;

const SeriesImages = () => {
const { imageType, seriesId } = useParams();

Expand All @@ -47,7 +45,7 @@ const SeriesImages = () => {
if (!imageType) return 'Posters';
return capitalize(imageType) as ImageTabType;
}, [imageType]);
const [selectedImage, setSelectedImage] = useState<ImageType>(nullImage);
const [selectedImage, setSelectedImage] = useState<ImageType | null>(null);
const images = useSeriesImagesQuery(toNumber(seriesId!), !!seriesId).data;
const { mutate: changeImage } = useChangeSeriesImageMutation();

Expand All @@ -56,20 +54,21 @@ const SeriesImages = () => {
const filepath = splitPath[0] ? splitPath.join('/') : '-';

const handleSelectionChange = (item: ImageType) => {
setSelectedImage(old => ((old === item) ? nullImage : item));
setSelectedImage(old => ((old === item) ? null : item));
};

const handleSetPreferredImage = useEventCallback(() => {
if (!selectedImage) return;
changeImage({ seriesId: toNumber(seriesId), image: selectedImage }, {
onSuccess: () => {
setSelectedImage(nullImage);
setSelectedImage(null);
toast.success(`Series ${selectedImage.Type} image has been changed.`);
},
});
});

const handleTabChange = useEventCallback((newType: ImageTabType) => {
setSelectedImage(nullImage);
setSelectedImage(null);
navigate(`../images/${newType.toLowerCase()}`);
});

Expand Down Expand Up @@ -97,7 +96,7 @@ const SeriesImages = () => {
<Button
buttonType="primary"
buttonSize="normal"
disabled={selectedImage === nullImage || selectedImage.Preferred}
disabled={!selectedImage || selectedImage.Preferred}
onClick={handleSetPreferredImage}
>
{`Set As Preferred ${tabType.slice(0, -1)}`}
Expand All @@ -124,7 +123,7 @@ const SeriesImages = () => {
{images?.[tabType].map(item => (
<div
onClick={() => handleSelectionChange(item)}
key={item?.ID}
key={`${item.Source}-${item.Type}-${item.ID}`}
className="group flex cursor-pointer items-center justify-between"
>
<BackgroundImagePlaceholderDiv
Expand Down