Support stackprof's ignore_gc option #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonhl
reviewed
Apr 7, 2022
jasonhl
approved these changes
Apr 7, 2022
swalkinshaw
force-pushed
the
support-ignoregc-option
branch
2 times, most recently
from
be7cac3
to
c24ed1c
Compare
gmcgibbon
reviewed
Apr 14, 2022
swalkinshaw
force-pushed
the
support-ignoregc-option
branch
from
c24ed1c
to
437dc9c
Compare
Allows the `ignore_gc` boolean option and passes it through to stackprof. > By default, samples taken during garbage collection will show as garbage collection frames including both mark and sweep phases. > For longer traces, these can leave gaps in a flamegraph that are hard to follow. They can be disabled by setting the ignore_gc option to true. > Garbage collection time will still be present in the profile but not explicitly marked with its own frame.
swalkinshaw
force-pushed
the
support-ignoregc-option
branch
from
437dc9c
to
9b16db2
Compare
|
Added to README 👍 |
gmcgibbon
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the
ignore_gcboolean option and passes it through to stackprof.