Use default formatter when profile_url_formatter is nil #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should find what is setting this to app_profiler/lib/app_profiler.rb Line 44 in 7e76516 |
kimbilida
commented
Jul 7, 2022
rafaelfranca
approved these changes
Jul 12, 2022
Set default formatter in initializer don't redirect if formatter is nil pr review fix load order update changelog
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why we have a nil formatter coming in from shopify but regardless we should handle the case when it's
nil. This change makes it more similar to the original code that uses the default formatter when it's nil.I've tested this revision in shopify/shopify and the tests are passing.
Questions:
Should I bump the version as part of this PR?
see: #52