Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profle Server] Fix typo in docs and require active_support #59

Merged
merged 1 commit into from
Aug 11, 2022
Merged

[Profle Server] Fix typo in docs and require active_support #59

merged 1 commit into from
Aug 11, 2022

Conversation

bmansoob
Copy link
Contributor

Two changes:

  1. Fix a typo in docs for starting the server, should be start! instead of start
  2. Require active_support, in case it is not loaded on the client side.

dalehamel
dalehamel approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@dalehamel dalehamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we can revisit removing the active_support deps if we cut the server out to another gem, or need to support any "pure ruby" apps

@bmansoob bmansoob merged commit 432cda7 into main Aug 11, 2022
@bmansoob bmansoob deleted the profile-server-updates branch August 11, 2022 16:37
rafaelfranca
rafaelfranca reviewed Aug 16, 2022
View reviewed changes
lib/app_profiler/server.rb
@@ -3,6 +3,7 @@
require "socket"
require "rack"
require "tempfile"
require "active_support/core_ext"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No gem should require all core extensions. Can you please revert this and fix requiring only what this gem needs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind if we fix forward @rafaelfranca ? I made #62

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol #61 🙈

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like at the same time @bmansoob also made #61 so i closed mine.

@bmansoob bmansoob mentioned this pull request Aug 16, 2022
Merged
@shopify-shipit shopify-shipit bot temporarily deployed to production September 23, 2022 18:56 Inactive
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelfranca rafaelfranca rafaelfranca left review comments

@dalehamel dalehamel dalehamel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmansoob @rafaelfranca @dalehamel