Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with latest Bundler #64

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

deivid-rodriguez
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez commented Nov 9, 2023

I checked if it passes all tests.

There was an issue, but I fixed it upstream though rubygems/rubygems#7066.

@deivid-rodriguez deivid-rodriguez force-pushed the bump-tested-bundler branch 2 times, most recently from 7b16540 to 9df490d Compare November 10, 2023 11:19
@deivid-rodriguez
Copy link
Contributor Author

I figured out the issue.

Current tests use plugin as a git source pointing to a branch. However, I think git rev-parse --abbrev-ref HEAD is returning HEAD in CI. Old Bundler dealed with that fine because it cloned full repositories but Bundler 2.4 only clones the revisions needed and HEAD is ambiguous.

I think this is a test-only issue and I changed the tests to use a path source instead to fix that. I think path is more adequate anyways because it allows to test your changes more directly.

Copy link
Contributor

@jenshenny jenshenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jenshenny jenshenny merged commit 2d179a6 into Shopify:main Apr 2, 2024
5 checks passed
@deivid-rodriguez deivid-rodriguez deleted the bump-tested-bundler branch April 3, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants